Update MC2 #1
Merged
Update MC2 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CohenCyril
reviewed
Apr 3, 2024
semialgebraic.v
Outdated
Comment on lines
1361
to
1364
| HB.instance Definition SAset_latticeType := | ||
| Order.isMeetJoinDistrLattice.Build SAset_disp _ le_meet (fun _ _ => erefl) commutative_meet commutative_join | ||
| associative_meet associative_join meet_join join_meet left_distributive_meet_join idempotent_meet. |
There was a problem hiding this comment.
Instances must always have a key. Here {SAset _}.
There was a problem hiding this comment.
I just opened this:
math-comp/hierarchy-builder#417
|
There is only the end of |
|
@Tragicus can I merge this so we have a mc2 version up and running with CI? |
|
I think so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tries toPorts the content of cad to math-comp 2.