Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

going back to the initial avro-serde-php as it's better than using a … #331

Conversation

mihaileu
Copy link
Contributor

…fork with no support

Copy link
Owner

@mateusjunges mateusjunges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, the switch to a fork wasn’t exactly a random whim. The original repo was unmaintained for 8 months, so I went with something I could actually rely on. If the original repo is now some shining beacon of active development, that’s awesome, but I’ll stick with the fork for now. It’s reliable and I can update it whenever needed.

By the way, PHP 8.4 is barely a month old. I handle this project and my other open source contributions in my free time, so yeah, I might fall a little behind new releases sometimes. But hey, PR's are always welcome!

Just fixed the warnings on my fork.

@@ -6,7 +6,7 @@
"php": "^8.1|^8.2",
"ext-rdkafka": "^5.0|^6.0",
"monolog/monolog": "^3.4",
"mateusjunges/avro-serde-php": "^3.0",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The repo was tagged as v2.2.0. This is not correct.

@mihaileu
Copy link
Contributor Author

hi, thx for your support. Just to know, I tried to create a PR on your fork, but I receive an error yesterday that I'm not a contributor or something related.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants