Skip to content

Commit

Permalink
update comment
Browse files Browse the repository at this point in the history
  • Loading branch information
computron committed Jul 18, 2020
1 parent 2b717f2 commit a2b14e3
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions fireworks/core/firework.py
Original file line number Diff line number Diff line change
Expand Up @@ -818,9 +818,8 @@ def apply_action(self, action, fw_id):
"""
updated_ids = []

# TODO: wouldn't it be better to update specs after inserting additions
# and detours in order to propagate modified specs to new FireWorks
# as well?
# note: update specs before inserting additions to give user more control
# see: https://github.com/materialsproject/fireworks/pull/407

# update the spec of the children FireWorks
if action.update_spec and action.propagate:
Expand Down

0 comments on commit a2b14e3

Please sign in to comment.