Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download links generator & all drivers wd execlusions #550

Open
wants to merge 4 commits into
base: v4-dev
Choose a base branch
from

Conversation

willinghamthesecond
Copy link

Download links provider: When ran, it will ask you for file location, doesn't matter what the extension is ( till now ), then will provide you with file direct download link ( can be used by curl ).

All drivers WD exclusion: Adds all drivers ( A:\ - Z:\ ) to Windows Security scan exclusion, so it will technically not work at all but just says that it is working with the icon shown.

@Yaw-Dev
Copy link
Collaborator

Yaw-Dev commented Jul 15, 2024

When adding something to /features it'd be best to make it into a command

Before it would run twice, first time will run great but second time comes with admin error:
```
Add-MpPreference : Operation failed with the following error: 0x%1!x!
At line:1 char:1
+ Add-MpPreference -ExclusionPath "A"
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (MSFT_MpPreference:root\Microsoft\...FT_MpPreference) [Add-MpPreference], CimException
    + FullyQualifiedErrorId : HRESULT 0xc0000142,Add-MpPreference
```

so now it will run only once but needs previous admin in order to run successfully.
@nasaofficial
Copy link

When adding something to /features it'd be best to make it into a command

Aight imma make it a command rn,

…ugh.

It takes a bit long time but it is worth it ( about 3 - 3.5 mins ).
@Yaw-Dev
Copy link
Collaborator

Yaw-Dev commented Jul 16, 2024

Also it's a good practise to make separate prs for each addition since they are completely unrelated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants