Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the Fake Notifications #391

Open
wants to merge 1 commit into
base: v4-dev
Choose a base branch
from

Conversation

willinghamthesecond
Copy link

Added more templates and fixed some issues

Added more templates and fixed some issues
Copy link

@Minecradt Minecradt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

@0-x-P
Copy link

0-x-P commented Jun 5, 2024

Hey! I would just ask if you could replace the if/elifs with a match/case system. Improves performance :)

@Yaw-Dev
Copy link
Collaborator

Yaw-Dev commented Jun 5, 2024

Hey! I would just ask if you could replace the if/elifs with a match/case system. Improves performance :)

according to mategol (the original creator) this project started with virtually no if statements and used match cases instead. Apparently some people complained about it tho so he changed it (idk why they would complain)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants