Develop #1520
Open
Develop #1520
+580
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volodymyr-soltys97
suggested changes
Nov 18, 2024
src/components/TodoItem.tsx
Outdated
| return; | ||
| } | ||
|
|
||
| // Якщо заголовок порожній, спробувати видалити туду |
There was a problem hiding this comment.
Remove all comments
Suggested change
| // Якщо заголовок порожній, спробувати видалити туду |
src/components/TodoItem.tsx
Outdated
Comment on lines
105
to
108
| onDoubleClick={() => { | ||
| setIsEditingMode(true); | ||
| setEditedTitle(todo.title); | ||
| }} |
There was a problem hiding this comment.
Move this logic to the helper function and use it here
src/components/Footer.tsx
Outdated
| return ( | ||
| <footer className="todoapp__footer" data-cy="Footer"> | ||
| <span className="todo-count" data-cy="TodosCounter"> | ||
| {`${activeCount} item${activeCount === 1 ? '' : 's'} left`} |
There was a problem hiding this comment.
Move this logic to the helper variable and use it here
src/App.tsx
Outdated
Comment on lines
212
to
213
| onRemoveTodo={() => {}} | ||
| onToggleTodoCompletion={() => {}} |
There was a problem hiding this comment.
Do you need these empty props?
src/App.tsx
Outdated
| todo={tempTodo} | ||
| onRemoveTodo={() => {}} | ||
| onToggleTodoCompletion={() => {}} | ||
| onUpdateTodoTitle={async (todo: Todo) => todo.title} |
There was a problem hiding this comment.
Suggested change
| onUpdateTodoTitle={async (todo: Todo) => todo.title} | |
| onUpdateTodoTitle={(todo: Todo) => todo.title} |
src/components/Footer.tsx
Outdated
Comment on lines
27
to
56
| <a | ||
| href="#/" | ||
| className={cn('filter__link', { | ||
| selected: filter === Filter.all, | ||
| })} | ||
| data-cy="FilterLinkAll" | ||
| onClick={() => setFilter(Filter.all)} | ||
| > | ||
| All | ||
| </a> | ||
|
|
||
| <a | ||
| href="#/active" | ||
| className={cn('filter__link', { | ||
| selected: filter === Filter.active, | ||
| })} | ||
| data-cy="FilterLinkActive" | ||
| onClick={() => setFilter(Filter.active)} | ||
| > | ||
| Active | ||
| </a> | ||
|
|
||
| <a | ||
| href="#/completed" | ||
| className={cn('filter__link', { | ||
| selected: filter === Filter.completed, | ||
| })} | ||
| data-cy="FilterLinkCompleted" | ||
| onClick={() => setFilter(Filter.completed)} | ||
| > |
There was a problem hiding this comment.
Use Object.values(your created enum) and render these options with map() method
src/App.tsx
Outdated
Comment on lines
198
to
208
| <section className="todoapp__main" data-cy="TodoList"> | ||
| {filteredTodos.map(todo => ( | ||
| <TodoItem | ||
| todo={todo} | ||
| key={todo.id} | ||
| onRemoveTodo={handleDeleteTodo} | ||
| onToggleTodoCompletion={handleTodoStatusChange} | ||
| onUpdateTodoTitle={handleRenameTodo} | ||
| isLoading={isLoading.includes(todo.id)} | ||
| /> | ||
| ))} |
There was a problem hiding this comment.
Move this logic to the separate TodoList component
|
@volodymyr-soltys97, Thank you very much for all the recommendations! The code has been rewritten. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK