commit -for fe-chat problem with swiper #196
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mykhalenych
suggested changes
Jul 26, 2023
IvanFesenko
suggested changes
Aug 1, 2023
There was a problem hiding this comment.
Add some message if there are no item for category
Check this case. You should reset selected page on itemsPerPage change
https://github.com/mate-academy/react_phone-catalog/assets/61904995/24e043ba-7c53-447e-8a11-580f902126a6
Add to card button should have cursor:pointer
https://github.com/mate-academy/react_phone-catalog/assets/61904995/2d60b018-f3f6-422f-becc-2d5de8d5e562
Those buttons didn't work
Add message if there no results on search
Check this case
VitaliyBondarenko1982
suggested changes
Aug 5, 2023
Viktor-Kost
suggested changes
Aug 7, 2023
There was a problem hiding this comment.
Hello!
Nice work!
Pay attention at these previous mentor's comments
#196 (comment)
#196 (review) (page should be centered)
To improve:
- make colors be selectable similar to capacity one
Screen.Recording.2023-08-07.at.21.39.46.mov
- Remove extra black background at images and use correct sizes since the last image is distorted
Screen.Recording.2023-08-07.at.21.41.06.mov
- add a condition to avoid selecting less than 1
- case: I enter a query. Found nothing. Click at logo. Click at tab. See no products and no query at input. It's a little bit confusing. Either leave an input query, or reload page
Screen.Recording.2023-08-07.at.21.45.58.mov
- As a recommendation: if a product is selected write "remove from card" at the button
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-DEMO LINK