Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add solution #236

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions .github/workflows/test.yml-template
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
name: Test

on:
pull_request:
branches: [ master ]

jobs:
build:

runs-on: ubuntu-latest

strategy:
matrix:
node-version: [20.x]

steps:
- uses: actions/checkout@v2
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}
- run: npm install
- run: npm test
9 changes: 5 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"devDependencies": {
"@faker-js/faker": "^8.4.1",
"@mate-academy/eslint-config": "latest",
"@mate-academy/scripts": "^1.8.6",
"@mate-academy/scripts": "^1.9.12",
"eslint": "^8.57.0",
"eslint-plugin-jest": "^28.6.0",
"eslint-plugin-node": "^11.1.0",
Expand Down
61 changes: 60 additions & 1 deletion src/app.js
Original file line number Diff line number Diff line change
@@ -1 +1,60 @@
// write code here
/* eslint-disable no-param-reassign */
/* eslint-disable no-shadow */
/* eslint-disable no-console */
'use strict';

const fs = require('fs');
const path = require('path');

const moveFiles = (source, destination) => {
if (!source) {
throw new Error('Source must be provided');
}

if (!destination) {
throw new Error('Destination must be provided');
}

const resolvedSource = path.resolve(source);
const resolvedDestination = path.resolve(destination);

if (resolvedSource === resolvedDestination) {
return;
}

if (!fs.existsSync(source)) {
throw new Error(`${source} doesn't exist, check the file path`);
}

const sourceStats = fs.statSync(source);

if (!sourceStats.isFile()) {
throw new Error('Only files can be moved');
}

const destStats = fs.existsSync(destination) && fs.statSync(destination);

if (destStats && destStats.isDirectory()) {
const fileName = path.basename(source);

destination = path.join(destination, fileName);
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line reassigns the destination parameter, which is generally not recommended as it can lead to confusion. Consider using a different variable name for the new destination path.


const parentDir = path.dirname(destination);

if (!fs.existsSync(parentDir)) {
throw new Error(`Destination directory ${parentDir} doesn't exist`);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The check here only verifies if the parent directory exists, but it doesn't ensure that the destination path is writable. Consider adding a check to ensure the destination is writable to prevent potential errors during the file move operation.

}

fs.renameSync(source, destination);

console.log(`File moved from ${source} to ${destination}`);
};

const [source, destination] = process.argv.slice(2);

try {
moveFiles(source, destination);
} catch (err) {
console.error(err.message);
}
Loading