-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add solution #236
base: master
Are you sure you want to change the base?
add solution #236
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
name: Test | ||
|
||
on: | ||
pull_request: | ||
branches: [ master ] | ||
|
||
jobs: | ||
build: | ||
|
||
runs-on: ubuntu-latest | ||
|
||
strategy: | ||
matrix: | ||
node-version: [20.x] | ||
|
||
steps: | ||
- uses: actions/checkout@v2 | ||
- name: Use Node.js ${{ matrix.node-version }} | ||
uses: actions/setup-node@v1 | ||
with: | ||
node-version: ${{ matrix.node-version }} | ||
- run: npm install | ||
- run: npm test |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,60 @@ | ||
// write code here | ||
/* eslint-disable no-param-reassign */ | ||
/* eslint-disable no-shadow */ | ||
/* eslint-disable no-console */ | ||
'use strict'; | ||
|
||
const fs = require('fs'); | ||
const path = require('path'); | ||
|
||
const moveFiles = (source, destination) => { | ||
if (!source) { | ||
throw new Error('Source must be provided'); | ||
} | ||
|
||
if (!destination) { | ||
throw new Error('Destination must be provided'); | ||
} | ||
|
||
const resolvedSource = path.resolve(source); | ||
const resolvedDestination = path.resolve(destination); | ||
|
||
if (resolvedSource === resolvedDestination) { | ||
return; | ||
} | ||
|
||
if (!fs.existsSync(source)) { | ||
throw new Error(`${source} doesn't exist, check the file path`); | ||
} | ||
|
||
const sourceStats = fs.statSync(source); | ||
|
||
if (!sourceStats.isFile()) { | ||
throw new Error('Only files can be moved'); | ||
} | ||
|
||
const destStats = fs.existsSync(destination) && fs.statSync(destination); | ||
|
||
if (destStats && destStats.isDirectory()) { | ||
const fileName = path.basename(source); | ||
|
||
destination = path.join(destination, fileName); | ||
} | ||
|
||
const parentDir = path.dirname(destination); | ||
|
||
if (!fs.existsSync(parentDir)) { | ||
throw new Error(`Destination directory ${parentDir} doesn't exist`); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The check here only verifies if the parent directory exists, but it doesn't ensure that the destination path is writable. Consider adding a check to ensure the destination is writable to prevent potential errors during the file move operation. |
||
} | ||
|
||
fs.renameSync(source, destination); | ||
|
||
console.log(`File moved from ${source} to ${destination}`); | ||
}; | ||
|
||
const [source, destination] = process.argv.slice(2); | ||
|
||
try { | ||
moveFiles(source, destination); | ||
} catch (err) { | ||
console.error(err.message); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line reassigns the
destination
parameter, which is generally not recommended as it can lead to confusion. Consider using a different variable name for the new destination path.