Develop #5070
Develop #5070
Conversation
There was a problem hiding this comment.
Thank you for your hard work on this project! 😊 While your code meets most of the task requirements, there are a few critical issues that need to be addressed before we can approve the pull request:
-
HTML Tag Issue: The
<html>tag is incorrectly self-closing. This is a critical issue as it affects the structure of your HTML document. Please remove the/at the end of the<html>tag to correct this. -
File Structure: The task requires each BEM block to have its own separate file. Currently, all styles are in a single CSS file. This needs to be adjusted to meet the task's core requirements.
These issues are important to resolve to ensure your code functions correctly and adheres to the task guidelines. Once these are fixed, your solution will be much stronger. Keep up the great work, and I look forward to seeing your updated code! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.
src/index.html
Outdated
| @@ -1,5 +1,8 @@ | |||
| <!doctype html> | |||
| <html lang="en"> | |||
| <html | |||
There was a problem hiding this comment.
The <html> tag should not be self-closing. Remove the / at the end of the tag to correct this.
There was a problem hiding this comment.
Great effort on addressing the HTML tag issue! 🎉 The <html> tag is now correctly structured, which is a significant improvement. However, please note that the task requires each BEM block to have its own separate CSS file. Currently, all styles are still in a single style.css file. This is a critical requirement that needs to be addressed to fully meet the task's guidelines.
Moving forward, ensure that each BEM block has its own CSS file to comply with the task requirements. This will help you better organize your code and adhere to best practices. Keep up the good work and continue learning from these experiences. Remember, addressing these issues will greatly enhance the functionality and maintainability of your code. 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
|
|
||
| .stars--5 .stars__star { | ||
| background-image: url(/src/images/star-active.svg); | ||
| } |
There was a problem hiding this comment.
The task requires each BEM block to have its own separate file. Currently, all styles are in a single CSS file. Please adjust the file structure to meet the task's core requirements.
No description provided.