Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution #5059

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Stanislav498
Copy link

.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Great job on implementing the task! 🎉 Your code meets the core requirements, and the HTML and CSS are well-structured. There are a few minor improvements you could consider, such as removing the unused .stars--6 selector and splitting the CSS into separate files for each BEM block for better organization. Keep up the good work, and happy coding! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

.stars--3 .stars__star:nth-child(-n + 3),
.stars--4 .stars__star:nth-child(-n + 4),
.stars--5 .stars__star:nth-child(-n + 5),
.stars--6 .stars__star:nth-child(-n + 6) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .stars--6 selector is defined here, but there is no corresponding HTML element in the index.html file with the class stars--6. If you do not plan to add a sixth star rating, you might want to remove this selector to keep the CSS clean and relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants