Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all tests passed #5056

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

EgorMamtsev
Copy link

-x Yellow stars are added with container modifier + pseudo-selector (NO extra classes)
-x Each BEM block has its own separate file
-x All Typical Mistakes from BEM lesson theory are checked.
-x Code follows all the Code Style Rules ❗️

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your hard work on this project! 😊 While your code meets most of the task requirements, there are a few critical issues that need to be addressed before we can proceed. Specifically, each BEM block should be in its own separate file, both for HTML and CSS, as per the task requirements. This organization is crucial for maintaining scalability and clarity in your code. Once these changes are made, your solution will be in great shape! Keep up the great work, and I look forward to seeing your improvements! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on addressing the previous issues regarding the organization of BEM blocks into separate files! 🎉 Your code now meets the task requirements, with each BEM block having its own CSS file and the HTML structure reflecting the correct use of BEM methodology. However, there are a couple of areas for improvement:

  • HTML Structure: Each BEM block should be in its own separate file to enhance scalability and clarity. Consider restructuring your HTML to meet these requirements.
  • Code Cleanup: The commented-out import statements in style.css are unnecessary and can be removed to tidy up the code.

These changes will help you maintain a clean and scalable codebase. Keep up the good work, and continue learning from these experiences! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Comment on lines +18 to +61
<div class="stars__wrapper">
<div class="stars stars--0">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<div class="stars stars--1">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<div class="stars stars--2">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<div class="stars stars--3">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<div class="stars stars--5">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
</div>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Each BEM block should be in its own separate file according to the task requirements. Consider separating the HTML structure for each block into different files to maintain scalability and clarity.

Comment on lines +1 to +3
/* @import url(blocks/body.css);
@import url(blocks/stars.css);
@import url(blocks/stars__star.css); */

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commented-out import statements are unnecessary and can be removed to clean up the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants