Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution #5051

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

marcosvinalves
Copy link

  • DEMO LINK

  • TEST REPORT LINK

  • Yellow stars are added with container modifier + pseudo-selector (NO extra classes)

  • Each BEM block has its own separate file

  • All Typical Mistakes from BEM lesson theory are checked.

  • Code follows all the Code Style Rules ❗️

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the star rating system! 🌟 Your code meets the task requirements, and the HTML and CSS structures are well-formed. While there are a few minor improvements suggested, such as separating BEM block styles into individual files and ensuring image paths are correct, these do not impact the core functionality. Keep up the good work and consider these suggestions for future enhancements!

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

}

.stars--1 .stars__star:nth-child(-n + 1) {
background-image: url(images/star-active.svg);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the path 'images/star-active.svg' is correct and that the file exists in the specified directory. This applies to all similar image paths in the file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants