done #5032
done #5032
Conversation
There was a problem hiding this comment.
Your implementation is almost there! 🎉 However, there are a few critical points that need addressing before we can approve the pull request. The main issues are the use of direct child selectors instead of pseudo-selectors for styling, and the need to separate BEM blocks into individual files as per the task requirements. These changes are essential to meet the core requirements of the task. Once these are resolved, your solution will be in great shape. Keep up the good work, and don't hesitate to reach out if you need any help! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.
There was a problem hiding this comment.
Great job on your submission! 🎉 Your code meets most of the task requirements and constraints, and it's clear that you've put in a lot of effort. Here are a few points to consider for improvement:
-
Separate CSS Files for BEM Blocks: While your CSS is well-organized, the task requires separate files for each BEM block. This is important for maintaining modular and scalable code. Please consider refactoring your styles into separate files.
-
Code Style Rules: Your code generally follows the style rules, but ensure that each BEM block has its own file to fully comply with the requirements.
Overall, your code is well-structured and functional. The decision to approve is made to help you move forward with your learning. Please review the comments and address the issues in future submissions to enhance your skills. Keep up the great work and continue to learn from each experience! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
[x] Yellow stars are added with container modifier + pseudo-selector (NO extra classes)
[x] Each BEM block has its own separate file
[x] All Typical Mistakes from BEM lesson theory are checked.
[x] Code follows all the Code Style Rules ❗️