-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
created stars block #5013
base: master
Are you sure you want to change the base?
created stars block #5013
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your hard work on this project! 😊 While your implementation is on the right track, there are a few critical issues that need to be addressed before we can approve the pull request:
-
Class Naming: The
div
elements for the stars should use the classstars
with modifiers likestars--0
,stars--1
, etc., instead ofstar
. This is important to meet the task requirements. -
Universal Selector: The use of the universal selector
*
in CSS for resetting margins and paddings is discouraged due to performance concerns. It's best to avoid this practice. -
BEM File Structure: Each BEM block should have its own separate CSS file. Currently, all styles are in a single
style.css
file, which doesn't align with the task requirements. -
Tag Names for Styling: Avoid using tag names for styling, except for
html
andbody
, as per the checklist guidelines.
Please address these issues to ensure your code meets the core requirements and maintains high standards for maintainability and performance. Keep up the great work, and feel free to reach out if you have any questions! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review
button in the Reviewers tab.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on your submission! 🎉 Your code meets most of the task requirements and constraints, and the HTML and CSS are well-structured for the most part. However, there are a few areas for improvement:
-
Use of Universal Selector: The universal selector
*
is used to reset margins and paddings, which can impact performance. It's better to target specific elements for resetting styles. -
BEM Structure: Each BEM block should have its own separate file, but currently, all styles are in a single CSS file. Consider organizing your styles according to BEM principles.
-
HTML and CSS Formatting: Ensure that all lines in your files adhere to the 80-character limit for better readability.
-
Missing Files: Make sure to include the
images
folder and the necessarystar.svg
andstar-active.svg
files referenced in your CSS. -
Semantic HTML: Use more semantic HTML elements instead of generic
div
elements to improve accessibility and SEO.
These issues should be addressed to fully comply with the task requirements. Remember, addressing these will not only improve your current project but also enhance your coding skills for future tasks. Keep up the great work and continue learning from your experiences! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
DEMO LINK
TEST REPORT LINK
[х] Yellow stars are added with container modifier + pseudo-selector (NO extra classes)
[х] Each BEM block has its own separate file
[х] All
Typical Mistakes
fromBEM
lesson theory are checked.[х] Code follows all the Code Style Rules ❗️