Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution #4993

Closed
wants to merge 2 commits into from
Closed

Conversation

PavloYurievich
Copy link

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your hard work on this project! 😊 While your implementation is mostly on point, there are a few critical issues that need to be addressed before we can approve the pull request:

  1. CSS Universal Selector: Using the universal selector * for resetting margins and paddings can impact performance. It's better to target specific elements instead.

  2. HTML Structure: The inclusion of a div with the class block-stars is not in line with the task requirements, which specify not to add any additional classes.

  3. BEM Methodology: The task requires each BEM block to have its own separate file. Please ensure that your implementation adheres to this requirement.

  4. Code Style: Make sure your code follows the specified style rules, such as using 2 spaces for indentation and keeping lines under 80 characters.

Addressing these issues will help ensure that your code meets the core requirements and maintains high standards for performance and maintainability. Keep up the great work, and I look forward to seeing your improvements! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

@PavloYurievich PavloYurievich closed this by deleting the head repository Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants