Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add task solution #4980

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add task solution #4980

wants to merge 1 commit into from

Conversation

d1nexl
Copy link

@d1nexl d1nexl commented Oct 21, 2024

mateacademy-ai-mentor
mateacademy-ai-mentor approved these changes Oct 21, 2024
View reviewed changes
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on structuring the HTML file! While there are some suggestions for improvement, such as using semantic tags and avoiding styling by tag names, these are minor and don't impact the core functionality. Keep up the good work and consider these tips for future projects! 🌟

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

src/index.html
@@ -13,6 +13,47 @@
/>
</head>
<body>
<h1>Stars</h1>
<div class="stars stars--0">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using semantic tags where possible. For example, if these 'stars' sections represent different sections of content, using a

tag might be more appropriate than a
.

src/style.css
padding: 0;
}

.stars {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid using tag names for styling, except for html and body. Consider using a class for the body element instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateacademy-ai-mentor mateacademy-ai-mentor mateacademy-ai-mentor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@d1nexl @mateacademy-ai-mentor