Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution #4979

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add task solution #4979

wants to merge 2 commits into from

Conversation

RHerheman
Copy link

  • DEMO LINK

  • TEST REPORT LINK

  • Yellow stars are added with container modifier + pseudo-selector (NO extra classes)

  • Each BEM block has its own separate file

  • All Typical Mistakes from BEM lesson theory are checked.

  • Code follows all the Code Style Rules ❗️

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on the functionality! While there are some suggestions for improving your CSS and HTML readability, they are minor and don't impact the core functionality of your code. Keep up the good work and consider these tips for future projects to enhance your code quality! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Comment on lines +22 to +23
</div>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be an empty line between multiline sibling blocks of HTML to improve readability. Please add an empty line here.

Comment on lines +30 to +31
</div>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be an empty line between multiline sibling blocks of HTML to improve readability. Please add an empty line here.

Comment on lines +38 to +39
</div>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be an empty line between multiline sibling blocks of HTML to improve readability. Please add an empty line here.

Comment on lines +46 to +47
</div>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be an empty line between multiline sibling blocks of HTML to improve readability. Please add an empty line here.

Comment on lines +54 to +55
</div>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be an empty line between multiline sibling blocks of HTML to improve readability. Please add an empty line here.

src/style.css Outdated
background-image: url(images/star-active.svg);
}

.stars--1 :nth-child(1) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid using tag names for styling. Instead of using ':nth-child(1)', consider using a class or another selector that doesn't involve tag names.

src/style.css Outdated
background-image: url(images/star-active.svg);
}

.stars--2 :nth-child(-n + 2) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid using tag names for styling. Instead of using ':nth-child(-n + 2)', consider using a class or another selector that doesn't involve tag names.

src/style.css Outdated
background-image: url(images/star-active.svg);
}

.stars--3 :nth-child(-n + 3) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid using tag names for styling. Instead of using ':nth-child(-n + 3)', consider using a class or another selector that doesn't involve tag names.

src/style.css Outdated
background-image: url(images/star-active.svg);
}

.stars--4 :nth-child(-n + 4) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid using tag names for styling. Instead of using ':nth-child(-n + 4)', consider using a class or another selector that doesn't involve tag names.

background-image: url(images/star-active.svg);
}

.stars--5 :nth-child(-n + 5) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid using tag names for styling. Instead of using ':nth-child(-n + 5)', consider using a class or another selector that doesn't involve tag names.

Copy link

@vadiimvooo vadiimvooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, but you have to pass all tests. Feel free to ask for help in fe_chat

src/style.css Outdated
Comment on lines 18 to 40
.stars--0 :nth-child(0) {
background-image: url(images/star-active.svg);
}

.stars--1 :nth-child(1) {
background-image: url(images/star-active.svg);
}

.stars--2 :nth-child(-n + 2) {
background-image: url(images/star-active.svg);
}

.stars--3 :nth-child(-n + 3) {
background-image: url(images/star-active.svg);
}

.stars--4 :nth-child(-n + 4) {
background-image: url(images/star-active.svg);
}

.stars--5 :nth-child(-n + 5) {
background-image: url(images/star-active.svg);
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.stars--0 :nth-child(0) {
background-image: url(images/star-active.svg);
}
.stars--1 :nth-child(1) {
background-image: url(images/star-active.svg);
}
.stars--2 :nth-child(-n + 2) {
background-image: url(images/star-active.svg);
}
.stars--3 :nth-child(-n + 3) {
background-image: url(images/star-active.svg);
}
.stars--4 :nth-child(-n + 4) {
background-image: url(images/star-active.svg);
}
.stars--5 :nth-child(-n + 5) {
background-image: url(images/star-active.svg);
}
.stars--0 :nth-child(0),
.stars--1 :nth-child(1),
.stars--2 :nth-child(-n + 2),
.stars--3 :nth-child(-n + 3),
.stars--4 :nth-child(-n + 4),
.stars--5 :nth-child(-n + 5) {
background-image: url(images/star-active.svg);
}

src/style.css Outdated
.stars__star {
width: 16px;
height: 16px;
padding-right: 4px;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use margin instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants