Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create BEM block stars with styles #4962

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

create BEM block stars with styles #4962

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a798f12
create BEM block stars with styles
TargoniyAnatoliy Oct 16, 2024
3423978
add changes after AI review
TargoniyAnatoliy Oct 16, 2024
2a7eb5f
add changes after 2-nd AI review
TargoniyAnatoliy Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

Implement the [Stars Block](https://www.figma.com/file/ojkArVazq7vsX0nbpn9CxZ/Moyo-%2F-Catalog-(ENG)?node-id=11325%3A2960) used in a card and catalog.

Hold `Alt` key (`Option` on MacOS) to measure distances in Figma.
Hold `Alt` key (`Option` on MacOS) to measure distances in Figma.

> Here are the [Layout Tasks Instructions](https://mate-academy.github.io/layout_task-guideline)

Expand All @@ -22,8 +22,8 @@ Hold `Alt` key (`Option` on MacOS) to measure distances in Figma.

❗️ Replace `<your_account>` with your Github username and copy the links to `Pull Request` description:

- [DEMO LINK](https://<your_account>.github.io/layout_stars/)
- [TEST REPORT LINK](https://<your_account>.github.io/layout_stars/report/html_report/)
- [DEMO LINK](https://TargoniyAnatoliy.github.io/layout_stars/)
- [TEST REPORT LINK](https://TargoniyAnatoliy.github.io/layout_stars/report/html_report/)

❗️ Copy this `Checklist` to the `Pull Request` description after links, and put `- [x]` before each point after you checked it.

Expand Down
91 changes: 83 additions & 8 deletions src/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,93 @@
<!doctype html>

<html lang="en">

<head>
<meta charset="UTF-8" />
<meta
name="viewport"

<meta name="viewport"
content="width=device-width, user-scalable=no, initial-scale=1.0, maximum-scale=1.0, minimum-scale=1.0"
/>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HTML Formatting issue: Remember to keep your attributes correctly formatted. If an HTML element has long attribute values or a number of attributes is more than 2, start each one on a new line with a 2-space indentation related to the tag. The tag's closing bracket should be on the same level as the opening one. In this case, the closing bracket '>' is on a new line which is not recommended.


<title>Stars</title>
<link
rel="stylesheet"
href="./style.css"
/>

<link rel="stylesheet" href="./style.css" />
</head>
<body>
<h1>Stars</h1>

<body class="body">
<div class="container">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HTML Content issue: It's better to use semantic tags where possible. The 'div' tag does not have any meaning. In this case, you could use the 'section' tag instead of 'div' to improve your page's SEO and help screen readers.

<div class="stars stars--0">
<div class="stars__star"></div>

<div class="stars__star"></div>

<div class="stars__star"></div>

<div class="stars__star"></div>

<div class="stars__star"></div>
</div>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HTML Formatting issue: Add empty lines between multiline sibling blocks of HTML to add some 'air' and simplify reading. But don't add them between parent and child elements. In this case, there should be an empty line after this 'div' block.


<div class="stars stars--1">
<div class="stars__star"></div>

<div class="stars__star"></div>

<div class="stars__star"></div>

<div class="stars__star"></div>

<div class="stars__star"></div>
</div>

<div class="stars stars--2">
<div class="stars__star"></div>

<div class="stars__star"></div>

<div class="stars__star"></div>

<div class="stars__star"></div>

<div class="stars__star"></div>
</div>

<div class="stars stars--3">
<div class="stars__star"></div>

<div class="stars__star"></div>

<div class="stars__star"></div>

<div class="stars__star"></div>

<div class="stars__star"></div>
</div>

<div class="stars stars--4">
<div class="stars__star"></div>

<div class="stars__star"></div>

<div class="stars__star"></div>

<div class="stars__star"></div>

<div class="stars__star"></div>
</div>

<div class="stars stars--5">
<div class="stars__star"></div>

<div class="stars__star"></div>

<div class="stars__star"></div>

<div class="stars__star"></div>

<div class="stars__star"></div>
</div>
</div>
</body>

</html>
46 changes: 45 additions & 1 deletion src/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,45 @@
/* add styles here */
.body {
margin: 0;
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have used the .body class for styling, but according to the checklist, we should not use tag names for styling, except html and body. Here, it seems you wanted to apply styles to the body tag, but you used a class instead. If you want to apply styles to the body tag, you should use body instead of .body. If .body is a class used in your HTML, consider renaming it to something more meaningful.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it done due to your previous recomendation


.container {
display: flex;
flex-direction: column;
}

.stars {
display: flex;
align-items: center;
}

.stars__star {
width: 16px;
height: 16px;
background-image: url(./images/star.svg);
background-repeat: no-repeat;
background-position: center;
}

Comment on lines +16 to +21
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good practice to specify a fallback background color for the case when the background image is not loaded. This is a recommendation.

.stars__star:not(:last-child) {
margin-right: 4px;
}

TargoniyAnatoliy marked this conversation as resolved.
Show resolved Hide resolved
.stars--1 :first-child {
background-image: url(./images/star-active.svg);
}

.stars--2 :nth-child(-n + 2) {
background-image: url(./images/star-active.svg);
}

.stars--3 :nth-child(-n + 3) {
background-image: url(./images/star-active.svg);
}

.stars--4 :nth-child(-n + 4) {
background-image: url(./images/star-active.svg);
}

.stars--5 :nth-child(-n + 5) {
background-image: url(./images/star-active.svg);
}
Loading