Develop #4957
Open
Develop #4957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateacademy-ai-mentor
approved these changes
Oct 16, 2024
VolodymyrKirichenko
suggested changes
Oct 16, 2024
src/stars.css
Outdated
Comment on lines
7
to
8
| /* justify-content: flex-start; | ||
| width: fit-content; */ |
src/stars.css
Outdated
Comment on lines
18
to
44
| .stars__star:not(:last-child) { | ||
| margin-right: 4px; | ||
| } | ||
|
|
||
| .stars--0 :nth-child(-n + 0) { | ||
| background-image: url(./images/star-active.svg); | ||
| } | ||
|
|
||
| .stars--1 :nth-child(-n + 1) { | ||
| background-image: url(./images/star-active.svg); | ||
| } | ||
|
|
||
| .stars--2 :nth-child(-n + 2) { | ||
| background-image: url(./images/star-active.svg); | ||
| } | ||
|
|
||
| .stars--3 :nth-child(-n + 3) { | ||
| background-image: url(./images/star-active.svg); | ||
| } | ||
|
|
||
| .stars--4 :nth-child(-n + 4) { | ||
| background-image: url(./images/star-active.svg); | ||
| } | ||
|
|
||
| .stars--5 :nth-child(-n + 5) { | ||
| background-image: url(./images/star-active.svg); | ||
| } |
There was a problem hiding this comment.
u can make it easier
Suggested change
| .stars__star:not(:last-child) { | |
| margin-right: 4px; | |
| } | |
| .stars--0 :nth-child(-n + 0) { | |
| background-image: url(./images/star-active.svg); | |
| } | |
| .stars--1 :nth-child(-n + 1) { | |
| background-image: url(./images/star-active.svg); | |
| } | |
| .stars--2 :nth-child(-n + 2) { | |
| background-image: url(./images/star-active.svg); | |
| } | |
| .stars--3 :nth-child(-n + 3) { | |
| background-image: url(./images/star-active.svg); | |
| } | |
| .stars--4 :nth-child(-n + 4) { | |
| background-image: url(./images/star-active.svg); | |
| } | |
| .stars--5 :nth-child(-n + 5) { | |
| background-image: url(./images/star-active.svg); | |
| } | |
| .stars--1 :nth-child(1), | |
| .stars--2 :nth-child(-n + 2), | |
| .stars--3 :nth-child(-n + 3), | |
| .stars--4 :nth-child(-n + 4), | |
| .stars--5 :nth-child(-n + 5) { | |
| background-image: url(images/star-active.svg); | |
| } |
src/stars.css
Outdated
Comment on lines
3
to
4
| margin: 0; | ||
| padding-left: 0; |
There was a problem hiding this comment.
u can make it above, for example:
body,
ul {
margin: 0;
padding: 0;
}
Suggested change
| margin: 0; | |
| padding-left: 0; |
But up to u)
src/body.css
Outdated
| @@ -0,0 +1,4 @@ | |||
| body { | |||
There was a problem hiding this comment.
change the name of the file - reset.css, instead body.css
This file will reset the properties and nothing more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solution failed pixel-perfect tests: the lines have an offset of 1 px
description of the problem in chat FS_OCT24_qna