Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution #4956

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

andrushchenkoo
Copy link

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on your HTML code! It's well formatted and follows best practices. You've used classes consistently and correctly. Just a couple of minor notes for the future: try to avoid using tag names for styling and apply the box-sizing property to all elements, not just the body tag. Keep up the good work! 👍

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

/* add styles here */
body {
margin: 0;
box-sizing: border-box;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should avoid using the box-sizing property on the body tag. This property should be applied to all elements on the page. This is done to ensure that the padding and border of an element no longer increase its width. You can do this by using the * selector, but remember, it's not recommended to use * selector for other styles. Here is how you can do it: css
*, *::before, *::after {
box-sizing: border-box;
}

Comment on lines +1 to +2
body {
margin: 0;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not recommended to use tag names for styling (except html and body). However, in this case, it's acceptable because you're setting a global style. Still, be mindful of this rule for other elements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants