Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add solution #4939

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add solution #4939

wants to merge 1 commit into from

Conversation

Fridrif27
Copy link

mateacademy-ai-mentor
mateacademy-ai-mentor approved these changes Oct 15, 2024
View reviewed changes
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on your code! There's just a minor issue with semantics - consider using a section tag instead of a div for your stars elements. It's a small change but it makes your code more organized and accessible. Keep up the good work! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

src/index.html
<body>
<h1>Stars</h1>
<body class="base__body">
<div>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The div tag on this line is a container for all your stars elements. It would be more semantic to use a section tag instead of a div tag here. section is a more descriptive tag and helps to organize the document into discrete sections, which can be useful for accessibility tools and SEO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateacademy-ai-mentor mateacademy-ai-mentor mateacademy-ai-mentor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fridrif27 @mateacademy-ai-mentor