add task solution #4937
add task solution #4937
Conversation
There was a problem hiding this comment.
Your code is well-structured and follows good practices. There are a few minor issues to consider for the future, like providing a fallback font-family and adjusting margin application, but they don't significantly impact the functionality of your code. Keep up the good work! 👍
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| @@ -1 +1,25 @@ | |||
| /* add styles here */ | |||
| body { | |||
| margin: 0; | |||
There was a problem hiding this comment.
You are using the body tag for styling. It's recommended to use classes instead of tag names for styling (except for html and body). So, this is acceptable in this case.
| @@ -1 +1,25 @@ | |||
| /* add styles here */ | |||
| body { | |||
| margin: 0; | |||
| } | |||
There was a problem hiding this comment.
You have not provided a fallback font-family. If the main one doesn't work, the browser will use a default one which may not fit your design.
| background-image: url(images/star.svg); | ||
| background-repeat: no-repeat; | ||
| background-position: center; | ||
| margin-right: 4px; |
There was a problem hiding this comment.
You have applied margin to the right of each star. This is not consistent with the guideline to apply margin only to the top or bottom of elements. Consider changing this to margin-bottom and adjusting your layout accordingly.
[x]Yellow stars are added with container modifier + pseudo-selector (NO extra classes)
[x]Each BEM block has its own separate file
[x]All Typical Mistakes from BEM lesson theory are checked.
[x]Code follows all the Code Style Rules ❗️