all tests #3776
Open
all tests #3776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volodymyr-soltys97
suggested changes
Nov 9, 2023
src/style.css
Outdated
Comment on lines
23
to
51
| .stars--0 .stars__star:nth-child(1), | ||
| .stars--0 .stars__star:nth-child(2), | ||
| .stars--0 .stars__star:nth-child(3), | ||
| .stars--0 .stars__star:nth-child(4), | ||
| .stars--0 .stars__star:nth-child(5) { | ||
| background-image: url(images/star.svg); | ||
| } | ||
|
|
||
| .stars--1 .stars__star:nth-child(2), | ||
| .stars--1 .stars__star:nth-child(3), | ||
| .stars--1 .stars__star:nth-child(4), | ||
| .stars--1 .stars__star:nth-child(5) { | ||
| background-image: url(images/star.svg); | ||
| } | ||
|
|
||
| .stars--2 .stars__star:nth-child(3), | ||
| .stars--2 .stars__star:nth-child(4), | ||
| .stars--2 .stars__star:nth-child(5) { | ||
| background-image: url(images/star.svg); | ||
| } | ||
|
|
||
| .stars--3 .stars__star:nth-child(4), | ||
| .stars--3 .stars__star:nth-child(5) { | ||
| background-image: url(images/star.svg); | ||
| } | ||
|
|
||
| .stars--4 .stars__star:nth-child(5) { | ||
| background-image: url(images/star.svg); | ||
| } |
There was a problem hiding this comment.
It looks quite complicated and a lot of code is duplicated, you need to simplify it and combine the selectors with a comma
|
@volodymyr-soltys97 all fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK
TEST REPORT LINK
Yellow stars are added with container modifier + pseudo-selector (NO extra classes)
Each BEM block has its own separate file
All
Typical MistakesfromBEMlesson theory are checked.Code follows all the Code Style Rules ❗️