-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add task solution #3767
base: master
Are you sure you want to change the base?
add task solution #3767
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done!
let's improve your code style a bit.
src/style.css
Outdated
background-position: center; | ||
width: 16px; | ||
height: 16px; | ||
margin-right: 4px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
disable margin for last child
src/style.css
Outdated
.stars--1 .stars__star:nth-child(1) { | ||
background-image: url(/images/star-active.svg); | ||
} | ||
|
||
.stars--2 .stars__star:nth-child(-n+2) { | ||
background-image: url(/images/star-active.svg); | ||
} | ||
|
||
.stars--3 .stars__star:nth-child(-n+3) { | ||
background-image: url(/images/star-active.svg); | ||
} | ||
|
||
.stars--4 .stars__star:nth-child(-n+4) { | ||
background-image: url(/images/star-active.svg); | ||
} | ||
|
||
.stars--5 .stars__star:nth-child(n) { | ||
background-image: url(/images/star-active.svg); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can combine these selectors with coma
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
DEMO LINK
TEST REPORT LINK
Yellow stars are added with container modifier + pseudo-selector (NO extra classes)
Each BEM block has its own separate file
All
Typical Mistakes
fromBEM
lesson theory are checked.Code follows all the Code Style Rules ❗️