Solution | layout-stars #3757
Open
Solution | layout-stars #3757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reyti
commented
Nov 1, 2023
Reyti
commented
- DEMO LINK
- TEST REPORT LINK
Viktor-Kost
suggested changes
Nov 1, 2023
| @@ -21,8 +21,8 @@ Follow | |||
|
|
|||
| ❗️ Replace `<your_account>` with your Github username and copy the links to `Pull Request` description: | |||
|
|
|||
| - [DEMO LINK](https://<your_account>.github.io/layout_stars/) | |||
| - [TEST REPORT LINK](https://<your_account>.github.io/layout_stars/report/html_report/) | |||
| - [DEMO LINK](https://Reyti.github.io/layout_stars/) | |||
There was a problem hiding this comment.
please check your deployment since DEMO link leads to readme.md and TEST link leads to 404 page
src/style.css
Outdated
Comment on lines
21
to
43
| .stars--0 .stars__star:nth-child(n):not(:nth-child(n+1)) { | ||
| background-image: url("images/star-active.svg"); | ||
| } | ||
|
|
||
| .stars--1 .stars__star:nth-child(n):not(:nth-child(n+2)) { | ||
| background-image: url("images/star-active.svg"); | ||
| } | ||
|
|
||
| .stars--2 .stars__star:nth-child(n):not(:nth-child(n+3)) { | ||
| background-image: url("images/star-active.svg"); | ||
| } | ||
|
|
||
| .stars--3 .stars__star:nth-child(n):not(:nth-child(n+4)) { | ||
| background-image: url("images/star-active.svg"); | ||
| } | ||
|
|
||
| .stars--4 .stars__star:nth-child(n):not(:nth-child(n+5)) { | ||
| background-image: url("images/star-active.svg"); | ||
| } | ||
|
|
||
| .stars--5 .stars__star:nth-child(n):not(:nth-child(n+6)) { | ||
| background-image: url("images/star-active.svg"); | ||
| } |
There was a problem hiding this comment.
use as a list
Suggested change
| .stars--0 .stars__star:nth-child(n):not(:nth-child(n+1)) { | |
| background-image: url("images/star-active.svg"); | |
| } | |
| .stars--1 .stars__star:nth-child(n):not(:nth-child(n+2)) { | |
| background-image: url("images/star-active.svg"); | |
| } | |
| .stars--2 .stars__star:nth-child(n):not(:nth-child(n+3)) { | |
| background-image: url("images/star-active.svg"); | |
| } | |
| .stars--3 .stars__star:nth-child(n):not(:nth-child(n+4)) { | |
| background-image: url("images/star-active.svg"); | |
| } | |
| .stars--4 .stars__star:nth-child(n):not(:nth-child(n+5)) { | |
| background-image: url("images/star-active.svg"); | |
| } | |
| .stars--5 .stars__star:nth-child(n):not(:nth-child(n+6)) { | |
| background-image: url("images/star-active.svg"); | |
| } | |
| .stars--0 .stars__star:nth-child(n):not(:nth-child(n+1)), | |
| .stars--1 .stars__star:nth-child(n):not(:nth-child(n+2)), | |
| .stars--2 .stars__star:nth-child(n):not(:nth-child(n+3)), | |
| .stars--3 .stars__star:nth-child(n):not(:nth-child(n+4)), | |
| .stars--4 .stars__star:nth-child(n):not(:nth-child(n+5)), | |
| .stars--5 .stars__star:nth-child(n):not(:nth-child(n+6)) { | |
| background-image: url("images/star-active.svg"); | |
| } |
src/style.css
Outdated
| @@ -0,0 +1,43 @@ | |||
| * { | |||
There was a problem hiding this comment.
it's not a good practice to reset styles using * selector
src/style.css
Outdated
| } | ||
|
|
||
| .stars__star { | ||
| margin: 0 2px; |
There was a problem hiding this comment.
use :not(:last-child) to set margin-right to each star besides last one
src/style.css
Outdated
|
|
||
| .stars__star { | ||
| margin: 0 2px; | ||
| margin-top: 2px; |
There was a problem hiding this comment.
redundant
Suggested change
| margin-top: 2px; |
src/style.css
Outdated
Comment on lines
14
to
15
| width: 16px; | ||
| height: 14px; |
There was a problem hiding this comment.
should have the same width and height
|
andriy-shymkiv
approved these changes
Nov 1, 2023
| background-image: url("images/star.svg"); | ||
| background-repeat: no-repeat; | ||
| background-position: center; | ||
| margin-right: 4px; |
There was a problem hiding this comment.
please remove margin-right for last child
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.