Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution #3750

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

maksym-walp
Copy link

@maksym-walp maksym-walp commented Oct 28, 2023

  • DEMO LINK

  • TEST REPORT LINK

  • Each BEM block has its own separate file

  • Yellow stars are added with container modifier + pseudo-selector (NO extra classes)

  • All Typical Mistakes from BEM lesson theory are checked.

  • Code follows all the Code Style Rules ❗️

Copy link

@nazarmatsevych nazarmatsevych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, let's improve your solution a bit:

  1. No need to add margin-right to the last stars in a row
    image

src/style.css Outdated
Comment on lines 19 to 41
.stars--0 .stars__star:nth-child(-n+0) {
background-image: url(images/star-active.svg);
}

.stars--1 .stars__star:nth-child(-n+1) {
background-image: url(images/star-active.svg);
}

.stars--2 .stars__star:nth-child(-n+2) {
background-image: url(images/star-active.svg);
}

.stars--3 .stars__star:nth-child(-n+3) {
background-image: url(images/star-active.svg);
}

.stars--4 .stars__star:nth-child(-n+4) {
background-image: url(images/star-active.svg);
}

.stars--5 .stars__star:nth-child(-n+5) {
background-image: url(images/star-active.svg);
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.stars--0 .stars__star:nth-child(-n+0) {
background-image: url(images/star-active.svg);
}
.stars--1 .stars__star:nth-child(-n+1) {
background-image: url(images/star-active.svg);
}
.stars--2 .stars__star:nth-child(-n+2) {
background-image: url(images/star-active.svg);
}
.stars--3 .stars__star:nth-child(-n+3) {
background-image: url(images/star-active.svg);
}
.stars--4 .stars__star:nth-child(-n+4) {
background-image: url(images/star-active.svg);
}
.stars--5 .stars__star:nth-child(-n+5) {
background-image: url(images/star-active.svg);
}
.stars--0 .stars__star:nth-child(-n+0),
.stars--1 .stars__star:nth-child(-n+1),
.stars--2 .stars__star:nth-child(-n+2),
.stars--3 .stars__star:nth-child(-n+3),
.stars--4 .stars__star:nth-child(-n+4),
.stars--5 .stars__star:nth-child(-n+5) {
background-image: url(images/star-active.svg);
}

Combine this selectors using comma

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@maksym-walp
Copy link
Author

Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants