Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add task solution #3749

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add task solution #3749

wants to merge 2 commits into from

Conversation

Laisens
Copy link

@Laisens Laisens commented Oct 28, 2023

volodymyr-soltys97
volodymyr-soltys97 suggested changes Oct 28, 2023
View reviewed changes
Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍
Let's improve your code

src/index.html Outdated
</div>

<div class="stars stars--1">
<div class="stars__star stars__star--active"></div>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to remove this classes everywhere and use nth-child for select stars

Suggested change
<div class="stars__star stars__star--active"></div>
<div class="stars__star"></div>

nazarmatsevych
nazarmatsevych approved these changes Oct 28, 2023
View reviewed changes
Copy link

@nazarmatsevych nazarmatsevych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nazarmatsevych nazarmatsevych nazarmatsevych approved these changes

@volodymyr-soltys97 volodymyr-soltys97 Awaiting requested review from volodymyr-soltys97

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Laisens @volodymyr-soltys97 @nazarmatsevych