Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add task solution #3514

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add task solution #3514

wants to merge 2 commits into from

Conversation

StasyaKukhniuk
Copy link

Viktor-Kost
Viktor-Kost suggested changes Aug 23, 2023
View reviewed changes
Copy link

@Viktor-Kost Viktor-Kost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost perfect! Well done!
Just minor fixes needed

src/index.html Outdated
<title>Stars</title>
<link rel="stylesheet" href="./style.css">
</head>
<!-- #endregion -->
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove comments

Suggested change
<!-- #endregion -->

src/index.html Outdated
Comment on lines 25 to 26
</div>
<div class="stars stars--1">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add an empty line between multiline siblings for better readability

Suggested change
</div>
<div class="stars stars--1">
</div>
<div class="stars stars--1">

src/style.css Outdated
Comment on lines 12 to 14
background-image: url(images/star.svg);
background-repeat: no-repeat;
background-position: center;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can apply background shorthand

IvanFesenko
IvanFesenko approved these changes Aug 24, 2023
View reviewed changes
Copy link

@IvanFesenko IvanFesenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IvanFesenko IvanFesenko IvanFesenko approved these changes

@Viktor-Kost Viktor-Kost Awaiting requested review from Viktor-Kost

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@StasyaKukhniuk @IvanFesenko @Viktor-Kost