add task solution #3507
Open
add task solution #3507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vovka8101
commented
Aug 22, 2023
vovka8101
commented
- DEMO LINK
- TEST REPORT LINK
etojeDenys
suggested changes
Aug 23, 2023
src/index.html
Outdated
Comment on lines
34
to
36
| <div class="stars__star star--active"></div> | ||
| <div class="stars__star star--active"></div> | ||
| <div class="stars__star star--active"></div> |
There was a problem hiding this comment.
we don't need these active classes, let's make our code more generic and implement logic only with this
VitaliyBondarenko1982
approved these changes
Aug 23, 2023
| @@ -0,0 +1,28 @@ | |||
| body { | |||
| margin: 0; | |||
| padding: 0; | |||
There was a problem hiding this comment.
Suggested change
| padding: 0; |
body doesn't have default paddings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.