Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solution #3505

Closed
wants to merge 4 commits into from
Closed

Solution #3505

wants to merge 4 commits into from

Conversation

katya-sn
Copy link

mykhalenych
mykhalenych suggested changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@mykhalenych mykhalenych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your links aren't working

src/index.html Outdated
</div>

<div class="stars star--1">
<div class="stars__star stars__star--active"></div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2023-08-22 at 07 10 36

missed requirements

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

я неправильно розумію вимоги - я додала в кожен з 5ти блоків клас stars--N ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, stars (not star)

volodymyr-soltys97
volodymyr-soltys97 suggested changes Aug 23, 2023
View reviewed changes
Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Demo link, you need to make deploy
image

src/index.html Outdated
Comment on lines 31 to 32
<div class="stars__star stars__star--active"></div>
<div class="stars__star stars__star--active"></div>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fix it everywhere

Suggested change
<div class="stars__star stars__star--active"></div>
<div class="stars__star stars__star--active"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>

@katya-sn
Copy link
Author

https://katya-sn.github.io/layout_stars/

mykhalenych
mykhalenych suggested changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@mykhalenych mykhalenych left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your test link isn't working

@katya-sn katya-sn closed this by deleting the head repository Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mykhalenych mykhalenych mykhalenych requested changes

@volodymyr-soltys97 volodymyr-soltys97 Awaiting requested review from volodymyr-soltys97

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@katya-sn @mykhalenych @volodymyr-soltys97