task solution v1.01 #3503
Open
task solution v1.01 #3503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VitaliyBondarenko1982
suggested changes
Aug 21, 2023
src/index.html
Outdated
Comment on lines
12
to
19
| <ul class="stars__list stars--0"> | ||
| <li class="stars__item"> | ||
| <div class="stars__star stars__star--inactive"></div> | ||
| </li> | ||
|
|
||
| <li class="stars__item"> | ||
| <div class="stars__star stars__star--inactive"></div> | ||
| </li> |
There was a problem hiding this comment.
Suggested change
| <ul class="stars__list stars--0"> | |
| <li class="stars__item"> | |
| <div class="stars__star stars__star--inactive"></div> | |
| </li> | |
| <li class="stars__item"> | |
| <div class="stars__star stars__star--inactive"></div> | |
| </li> | |
| <div class="stars stars--0"> | |
| <div class="stars__star"></div> | |
| <div class="stars__star"></div> | |
| ... |
stars is not a list. use just div.
no need any classes for star
use stars--1, stars--2... modifiers should be responsible about amount of active stars. use nth-child for it.
|
Hi, I have changed list to div and added nth-child to make stars active |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK
TEST REPORT LINK