-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add task solution MR #3471
add task solution MR #3471
Conversation
RuslanMelnykFE
commented
Aug 13, 2023
- DEMO LINK
- TEST REPORT LINK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good but your links are not working, try to run npm run deploy command again
src/index.html
Outdated
<ul class="stars stars--0"> | ||
<li class="stars__star"></li> | ||
<li class="stars__star"></li> | ||
<li class="stars__star"></li> | ||
<li class="stars__star"></li> | ||
<li class="stars__star"></li> | ||
</ul> | ||
<ul class="stars stars--1"> | ||
<li class="stars__star"></li> | ||
<li class="stars__star"></li> | ||
<li class="stars__star"></li> | ||
<li class="stars__star"></li> | ||
<li class="stars__star"></li> | ||
</ul> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<ul class="stars stars--0"> | |
<li class="stars__star"></li> | |
<li class="stars__star"></li> | |
<li class="stars__star"></li> | |
<li class="stars__star"></li> | |
<li class="stars__star"></li> | |
</ul> | |
<ul class="stars stars--1"> | |
<li class="stars__star"></li> | |
<li class="stars__star"></li> | |
<li class="stars__star"></li> | |
<li class="stars__star"></li> | |
<li class="stars__star"></li> | |
</ul> | |
<ul class="stars stars--0"> | |
<li class="stars__star"></li> | |
<li class="stars__star"></li> | |
<li class="stars__star"></li> | |
<li class="stars__star"></li> | |
<li class="stars__star"></li> | |
</ul> | |
<ul class="stars stars--1"> | |
<li class="stars__star"></li> | |
<li class="stars__star"></li> | |
<li class="stars__star"></li> | |
<li class="stars__star"></li> | |
<li class="stars__star"></li> | |
</ul> |
Add blank line between multiple sibling blocks of html
margin: 0; | ||
padding: 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't reset paddings and margins in * selector, reset them for tags you are using
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done 🔥