-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add task solution #3436
base: master
Are you sure you want to change the base?
add task solution #3436
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Almost perfect!
One small but important fix left 🙏
src/style.css
Outdated
.stars--1 .stars__star:nth-child(1) { | ||
background-image: url(/images/star-active.svg); | ||
} | ||
|
||
.stars--2 .stars__star:nth-child(-n+2) { | ||
background-image: url(/images/star-active.svg); | ||
} | ||
|
||
.stars--3 .stars__star:nth-child(-n+3) { | ||
background-image: url(/images/star-active.svg); | ||
} | ||
|
||
.stars--4 .stars__star:nth-child(-n+4) { | ||
background-image: url(/images/star-active.svg); | ||
} | ||
|
||
.stars--5 .stars__star:nth-child(-n+5) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
.stars { | ||
display: flex; | ||
flex-direction: row; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's actually a default value. No need to specify it, but it's not a problem
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better to delete that )
|
||
.stars { | ||
display: flex; | ||
flex-direction: row; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better to delete that )
DEMO LINK