Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution #3436

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add task solution #3436

wants to merge 2 commits into from

Conversation

iurche
Copy link

@iurche iurche commented Aug 4, 2023

Copy link

@polosanya polosanya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Almost perfect!
One small but important fix left 🙏

src/style.css Outdated
Comment on lines 20 to 36
.stars--1 .stars__star:nth-child(1) {
background-image: url(/images/star-active.svg);
}

.stars--2 .stars__star:nth-child(-n+2) {
background-image: url(/images/star-active.svg);
}

.stars--3 .stars__star:nth-child(-n+3) {
background-image: url(/images/star-active.svg);
}

.stars--4 .stars__star:nth-child(-n+4) {
background-image: url(/images/star-active.svg);
}

.stars--5 .stars__star:nth-child(-n+5) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image


.stars {
display: flex;
flex-direction: row;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's actually a default value. No need to specify it, but it's not a problem

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better to delete that )

@iurche iurche requested a review from polosanya August 4, 2023 12:17

.stars {
display: flex;
flex-direction: row;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better to delete that )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants