add task solution #3435
Closed
add task solution #3435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kulynychruslana
commented
Aug 3, 2023
•
kulynychruslana
commented
- DEMO LINK
- TEST REPORT LINK
mykhalenych
suggested changes
Aug 3, 2023
src/index.html
Outdated
| </svg> | ||
| </div> | ||
| <div class="stars__star"> | ||
| <svg xmlns="http://www.w3.org/2000/svg" |
There was a problem hiding this comment.
add background img instead
src/style.css
Outdated
| display: flex; | ||
| } | ||
|
|
||
| .stars__star { |
mykhalenych
suggested changes
Aug 4, 2023
src/style.css
Outdated
| margin-right: 4px; | ||
| } | ||
|
|
||
| .stars--1 :nth-child(1) { |
There was a problem hiding this comment.
Suggested change
| .stars--1 :nth-child(1) { | |
| .stars--1 :nth-child(1), | |
| .stars--2 :nth-child(-n + 2), | |
| .stars--3 :nth-child(-n + 3), | |
| ... { | |
| background-image: url(images/star-active.svg); | |
| } |
Esceype
suggested changes
Aug 5, 2023
src/style.css
Outdated
| margin-right: 4px; | ||
| } | ||
|
|
||
| .stars--1 :nth-child(1) { |
src/style.css
Outdated
Comment on lines
23
to
40
| background-image: url(images/star-active.svg); | ||
| } | ||
|
|
||
| .stars--2 :nth-child(-n + 2) { | ||
| background-image: url(images/star-active.svg); | ||
| } | ||
|
|
||
| .stars--3 :nth-child(-n + 3) { | ||
| background-image: url(images/star-active.svg); | ||
| } | ||
|
|
||
| .stars--4 :nth-child(-n + 4) { | ||
| background-image: url(images/star-active.svg); | ||
| } | ||
|
|
||
| .stars--5 :nth-child(-n + 5) { | ||
| background-image: url(images/star-active.svg); | ||
| } |
denys-danyliuk
suggested changes
Aug 7, 2023
Comment on lines
+11
to
+25
| <div class="container"> | ||
| <div class="stars stars--0"> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| </div> | ||
| <div class="stars stars--1"> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| </div> |
There was a problem hiding this comment.
Suggested change
| <div class="container"> | |
| <div class="stars stars--0"> | |
| <div class="stars__star"></div> | |
| <div class="stars__star"></div> | |
| <div class="stars__star"></div> | |
| <div class="stars__star"></div> | |
| <div class="stars__star"></div> | |
| </div> | |
| <div class="stars stars--1"> | |
| <div class="stars__star"></div> | |
| <div class="stars__star"></div> | |
| <div class="stars__star"></div> | |
| <div class="stars__star"></div> | |
| <div class="stars__star"></div> | |
| </div> | |
| <div class="container"> | |
| <div class="stars stars--0"> | |
| <div class="stars__star"></div> | |
| <div class="stars__star"></div> | |
| <div class="stars__star"></div> | |
| <div class="stars__star"></div> | |
| <div class="stars__star"></div> | |
| </div> | |
| <div class="stars stars--1"> | |
| <div class="stars__star"></div> | |
| <div class="stars__star"></div> | |
| <div class="stars__star"></div> | |
| <div class="stars__star"></div> | |
| <div class="stars__star"></div> | |
| </div> |
1'st point in checklist
Comment on lines
+22
to
+24
| .stars--1 :nth-child(1) , | ||
|
|
||
| .stars--2 :nth-child(-n + 2), |
There was a problem hiding this comment.
Suggested change
| .stars--1 :nth-child(1) , | |
| .stars--2 :nth-child(-n + 2), | |
| .stars--1 :nth-child(1) , | |
| .stars--2 :nth-child(-n + 2), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.