made first task #3420
Open
made first task #3420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xXPaRaZorXx
commented
Jul 31, 2023
•
xXPaRaZorXx
commented
- DEMO LINK
- TEST REPORT LINK
volodymyr-soltys97
suggested changes
Jul 31, 2023
Comment on lines
+3
to
+4
| - [DEMO LINK](https://xXPaRaZorXx.github.io/layout_stars/) | ||
| - [TEST REPORT LINK](https://xXPaRaZorXx.github.io/layout_stars/report/html_report/) |
There was a problem hiding this comment.
Add these links to PR description
src/style.css
Outdated
Comment on lines
25
to
47
| .stars--5 .stars__star { | ||
| background-image: url(images/star-active.svg); | ||
| } | ||
|
|
||
| .stars--0 .stars__star:nth-child(n+1) { | ||
| background-image: url(images/star.svg); | ||
| } | ||
|
|
||
| .stars--1 .stars__star:nth-child(-n+1) { | ||
| background-image: url(images/star-active.svg); | ||
| } | ||
|
|
||
| .stars--2 .stars__star:nth-child(-n+2) { | ||
| background-image: url(images/star-active.svg); | ||
| } | ||
|
|
||
| .stars--3 .stars__star:nth-child(-n+3) { | ||
| background-image: url(images/star-active.svg); | ||
| } | ||
|
|
||
| .stars--4 .stars__star:nth-child(-n+4) { | ||
| background-image: url(images/star-active.svg); | ||
| } |
volodymyr-soltys97
suggested changes
Aug 1, 2023
src/index.html
Outdated
Comment on lines
44
to
48
| <span class="stars__star"></span> | ||
| <span class="stars__star"></span> | ||
| <span class="stars__star"></span> | ||
| <span class="stars__star"></span> | ||
| <span class="stars__star"></span> |
There was a problem hiding this comment.
Should be only 1 spaces
Suggested change
| <span class="stars__star"></span> | |
| <span class="stars__star"></span> | |
| <span class="stars__star"></span> | |
| <span class="stars__star"></span> | |
| <span class="stars__star"></span> | |
| <span class="stars__star"></span> | |
| <span class="stars__star"></span> | |
| <span class="stars__star"></span> | |
| <span class="stars__star"></span> | |
| <span class="stars__star"></span> |
src/style.css
Outdated
Comment on lines
33
to
35
| .stars--0 .stars__star:nth-child(n+1) { | ||
| background-image: url(images/star.svg); | ||
| } |
There was a problem hiding this comment.
Redundant
Suggested change
| .stars--0 .stars__star:nth-child(n+1) { | |
| background-image: url(images/star.svg); | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.