add task solution #3412
Open
add task solution #3412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NataliaDavida
commented
Jul 29, 2023
•
NataliaDavida
commented
- DEMO LINK
- TEST REPORT LINK
denys-danyliuk
suggested changes
Jul 29, 2023
src/style.css
Outdated
|
|
||
| .stars { | ||
| display: flex; | ||
| width: 96px; |
There was a problem hiding this comment.
isn't fixed. No needs to hardcode width
Viktor-Kost
suggested changes
Jul 31, 2023
There was a problem hiding this comment.
Hello!)
Also, please check this comment since it wasn't fixed
#3412 (comment)
If you need any help feel free to ask at fe_chat
src/style.css
Outdated
| height: 16px; | ||
| background-repeat: no-repeat; | ||
| background-position: center; | ||
| color: #e5e5e5; |
There was a problem hiding this comment.
redundant
Suggested change
| color: #e5e5e5; |
src/style.css
Outdated
Comment on lines
11
to
15
| background-image: url("./images/star.svg"); | ||
| width: 16px; | ||
| height: 16px; | ||
| background-repeat: no-repeat; | ||
| background-position: center; |
src/style.css
Outdated
Comment on lines
19
to
47
| .stars__star:not(:last-child) { | ||
| margin-right: 4px; | ||
| } | ||
|
|
||
| .stars--5 .stars__star { | ||
| background-image: url("./images/star-active.svg"); | ||
| } | ||
|
|
||
| .stars--1 .stars__star:nth-child(1) { | ||
| background-image: url("./images/star-active.svg"); | ||
| } | ||
|
|
||
| .stars--2 .stars__star:nth-child(1), | ||
| .stars--2 .stars__star:nth-child(2) { | ||
| background-image: url("./images/star-active.svg"); | ||
| } | ||
|
|
||
| .stars--3 .stars__star:nth-child(1), | ||
| .stars--3 .stars__star:nth-child(2), | ||
| .stars--3 .stars__star:nth-child(3) { | ||
| background-image: url("./images/star-active.svg"); | ||
| } | ||
|
|
||
| .stars--4 .stars__star:nth-child(1), | ||
| .stars--4 .stars__star:nth-child(2), | ||
| .stars--4 .stars__star:nth-child(3), | ||
| .stars--4 .stars__star:nth-child(4) { | ||
| background-image: url("./images/star-active.svg"); | ||
| } |
There was a problem hiding this comment.
this type of adding styles isn't flexible. Imagine if you have a case with 10 stars or even more?
- use
:nth-child(-n + {{here_will_be_a_number_from_1_to_5}})
Example:
.my__star:nth-child(-n + 4) - if your selectors have the same style use them as a group
Example:
.my__selector1,
.my__selector2 {
color: #ff0000;
}
src/style.css
Outdated
|
|
||
| .stars { | ||
| display: flex; | ||
| width: 96px; |
There was a problem hiding this comment.
isn't fixed. No needs to hardcode width
Esceype
suggested changes
Aug 6, 2023
src/style.css
Outdated
Comment on lines
19
to
21
| .stars--5 .stars__star { | ||
| background-image: url("./images/star-active.svg"); | ||
| } |
There was a problem hiding this comment.
Move it down as other selectors for modifiers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.