add task solution #3384
add task solution #3384
Conversation
src/style.css
Outdated
| .stars--3 .stars_star:nth-child(-n + 3), | ||
| .stars--4 .stars_star:nth-child(-n + 4), | ||
| .stars--5 .stars_star:nth-child(-n + 5) { | ||
| background-image: url(images\star-active.svg); |
There was a problem hiding this comment.
The file path in CSS should use forward slashes, not backslashes. Replace 'images\star-active.svg' with 'images/star-active.svg'.
There was a problem hiding this comment.
VS Code made file path with backslashes automatically. Corrected it manually.
src/style.css
Outdated
| .stars_star { | ||
| width: 16px; | ||
| height: 16px; | ||
| background-image: url(images\star.svg); |
There was a problem hiding this comment.
The file path in CSS should use forward slashes, not backslashes. Replace 'images\star.svg' with 'images/star.svg'.
src/index.html
Outdated
| @@ -8,6 +8,54 @@ | |||
| <link rel="stylesheet" href="./style.css"> | |||
| </head> | |||
| <body> | |||
| <h1>Stars</h1> | |||
| <main class="main"> | |||
| <div class="stars stars--0"> | |||
There was a problem hiding this comment.
These HTML elements, following semantic tags should be rather instead of divs:
<ul>
<li></li>
<li></li>
...
</ul>
There was a problem hiding this comment.
Done.
One question. Why PR #3381 is done with divs and it's approved?
src/style.css
Outdated
| margin-left: 4px; | ||
| } | ||
|
|
||
| .stars--1 .stars_star:nth-child(-n + 1), |
There was a problem hiding this comment.
think using this selectors should be enough .stars--1 :nth-child(-n + 1),
.stars--2 :nth-child(-n + 1) etc..
https://mareksax.github.io/layout_stars/
https://mareksax.github.io/layout_stars/report/html_report/