-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add task solution #4749
base: master
Are you sure you want to change the base?
add task solution #4749
Conversation
Mazafakerqq
commented
Feb 3, 2025
- DEMO LINK
- TEST REPORT LINK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your hard work on this task! 😊 While your code is well-structured and follows many best practices, there are a few critical issues that need to be addressed to fully meet the task requirements.
-
Image Path: Ensure the image paths in your HTML file are correct. They should be
src/images/Search.svg
instead of../src/images/Search.svg
. -
CSS Styling: Avoid using tag names for styling in your CSS. Use class selectors instead, as per the checklist requirement.
-
HTML Structure: Correct the
data-qa
attribute for the input in the small search form tokeypress
as required. -
CSS Selectors: Apply the
:focus
pseudo-class to the input elements, not the container divs, to meet the task's state requirements. -
HTML Formatting: Ensure attributes are formatted correctly, with each attribute on a new line if there are more than two.
-
Missing Files: Include a
@font-face
declaration in your CSS to meet the task requirements.
Once these issues are resolved, your code will be in great shape! Keep up the great work, and don't hesitate to reach out if you need any help. 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review
button in the Reviewers tab.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Summary
Great progress on your project! 🎉 You've addressed many of the previous issues, but there are still some critical points that need attention to ensure your code is fully functional and meets the task requirements:
-
Image Path: The image paths in the HTML file are still incorrect. They should be
src/images/Search.svg
instead of../src/images/Search.svg
. This change is crucial for the images to display correctly. -
CSS Selectors: The
:focus
pseudo-class is currently applied to the container divs instead of the input elements. Ensure that the:focus
state is applied directly to the input elements to meet the task's requirements. -
@font-face Declaration: The
@font-face
declaration is present in the CSS file, but thesrc
attribute is empty. Please include the correct path to the font file to ensure proper font loading. -
CSS Styling: Avoid using tag names for styling in your CSS. Instead, use class selectors to make your styles more specific and maintainable.
These adjustments are important for the functionality and maintainability of your code. Although the decision is to APPROVE this pull request to help you move forward with your learning journey, it's crucial to address these issues in future iterations to avoid similar problems. Keep up the great work and continue improving your skills! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
data-qa="big" | ||
> | ||
<img | ||
src="src/images/Search.svg" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The image path should be src/images/Search.svg
instead of ../src/images/Search.svg
to correctly reference the image location.
data-qa="small" | ||
> | ||
<img | ||
src="src/images/Search.svg" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The image path should be src/images/Search.svg
instead of ../src/images/Search.svg
to correctly reference the image location.