add task solution #4746
add task solution #4746
Conversation
There was a problem hiding this comment.
There are a few critical issues that need to be addressed before we can approve your submission. The data-qa attribute is incorrectly set, the font-weight does not meet the specified requirement, and the file structure for images needs to be verified. Please make these adjustments, and you'll be all set! Keep up the great work, and don't hesitate to reach out if you need any help. 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.
There was a problem hiding this comment.
Thank you for your submission! 🎉 Your code has been reviewed, and while it meets the task requirements overall, there are a few areas that need attention:
-
data-qaAttribute: Please verify thedata-qaattributes for both the small and big search forms. They might not be set correctly according to the previous review. Ensure they align with the specified requirements. -
Font-weight: The
font-weightfor.search__input:focusis set to 600, and for.search__input, it is set to 300. Please ensure these values meet the specified requirements or adjust them accordingly. -
Font-size: The
font-sizefor the.bodyclass is set to 300px, which seems excessively large. Please verify if this is intentional or if it should be adjusted to a more typical size.
Despite these issues, the decision is to APPROVE your pull request to help you move forward with your learning journey. Please review the comments and address these issues in future submissions to enhance your coding skills. Keep up the great work and continue learning from these experiences! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| <body class="body"> | ||
| <form | ||
| class="search search--big" | ||
| data-qa="big" |
There was a problem hiding this comment.
The data-qa attribute is set to 'big', which might not be correct according to the previous review. Please verify and update it as needed.
| </form> | ||
| <form | ||
| class="search search--small" | ||
| data-qa="small" |
There was a problem hiding this comment.
The data-qa attribute is set to 'small', which might not be correct according to the previous review. Please verify and update it as needed.
|
|
||
| .body { | ||
| font-family: Avenir, sans-serif; | ||
| font-size: 300px; |
There was a problem hiding this comment.
The font-size for the .body class is set to 300px, which seems excessively large. Please verify if this is intentional or if it should be adjusted.
| border: 1px solid #e1e7ed; | ||
| border-radius: 4px; | ||
| box-shadow: 0 1px 8px 0 #3d4e611a; | ||
| font-weight: 300; |
There was a problem hiding this comment.
The font-weight for .search__input is set to 300. Ensure this meets the specified requirement or adjust accordingly.
|
|
||
| .search__input:focus { | ||
| background: linear-gradient(180deg, #fff 0%, #f6f6f7 100%); | ||
| font-weight: 600; |
There was a problem hiding this comment.
The font-weight for .search__input:focus is set to 600. Ensure this meets the specified requirement or adjust accordingly.
DEMO LINK
TEST REPORT LINK
Icon implemented using background-image CSS property
Inputs are written inside of 'form' tag with correctly passed attributes
All
Typical MistakesfromBEMlesson theory are checked.Code follows all the Code Style Rules ❗️