Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution #1820

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

GuilhermeSant
Copy link

make the project for MET Landing page with this rules

url:
https://GuilhermeSant.github.io/layout_landing-page

  1. Use the logo as a favicon
  2. Use the landing name as a page title
  3. All logos should be links to the top of the page
  4. Change text color on hover for phone, email, and address
  5. Make sure phone icons and phone numbers are real links to start a call
  6. All addresses should be links to some location on Google Maps. Open them in a new tab with target="_blank".
  7. Increase all images on hover (make them links to #, if there is no better option)
  8. Make sure everything looks neat on mobile and without horizontal scrolling
  9. The speed of animations should be the same throughout the page (for example, increasing when hovering or moving blocks when scrolling)
  10. Ensure that all nav__links work smoothly
  11. Disable page scrolling under the menu using the next code:
    .page:has(.page__menu:target) {
      overflow: hidden; /* not to scroll the page */
    }
  12. Make it possible to scroll the menu if it is higher than the viewport;
    .menu {
      overflow: auto; /* to scroll the menu if needed */
    }
    .menu__top {
      position: sticky; /* to keep cross always visible */
      top: 0;
      z-index: 1;
      background-color: #e5e5e5;
    }
  13. All form fields should be required and have correct types (email, tel, etc.)
  14. Placeholders should give examples of what should be added, to make the expected format clear
  15. The page shouldn't be reloaded on form submit, but the fields should be cleared. Use:
    <form onsubmit="this.reset(); return false;">
  16. Make the footer sticky at the bottom with z-index: -1 to get a fixed background effect.

@joaorpereira
Copy link

@GuilhermeSant the gap value of 100px is adding a bottom after the footer section:

Screenshot 2024-11-18 at 11 49 29 AM

Copy link

@joaorpereira joaorpereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments

@GuilhermeSant
Copy link
Author

make adjusts for resolution 1024px and footer sticky

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants