Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

layout_landing-page #1817

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

leraMeleshchenko
Copy link

Landing page

This project is a landing page created to showcase the Nothing(R) brand product.
It features a responsive layout, ensuring an optimal display across various devices.

Here is my project (https://leraMeleshchenko.github.io/layout_landing-page/)

and this is design for this project

Technologies that were used:

  • HTML
  • SASS
  • BEM
  • Flexbox
  • Grid.

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍
Let's improve your page

  1. Add the topical title and favicon on the page
image
  1. Check font styles for the phone number, check it on the design
image
  1. You need to disable scroll when the menu is open
image
  1. Add hover effects for images
image
  1. The user cannot ba able to change size of the textarea filed
image
  1. Make all these fields are required before sending
image

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍
To improve:

  1. After submit the form don't need to refresh page and scroll to top, you need only reset form fields
image
  1. Add hover effects for these images
image
  1. This element must be link on google maps
image
  1. Add hover effects bere
image
  1. You need to make a call when user clicks on the phone icon
image

@leraMeleshchenko
Copy link
Author

4.Add hover effects bere. - what should be the hover effects here? The design includes nothing

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done!
To improve:

  1. You need to add transition for hover effects here
image
  1. Need to hide the additional phone number on the mobile and tablet versions. Also, you need to make a call when user clicks here
image

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants