Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Landing-page #1816

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Landing-page #1816

wants to merge 1 commit into from

Conversation

zhudim
Copy link

@zhudim zhudim commented Nov 13, 2024

  • Deploy and create a Pull Request with a DEMO LINK

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍
Let's improve your page

  1. Add the topical title and favicon on the page
image
  1. Need to reset default margin for the body

  2. Add the horizontal padding for the content

image
  1. Add hover effects for all clickable elements
image
  1. Need to show additional phone number when hovering this icon
image
  1. Add transition when the menu appears on the page, also, remove scroll when the menu is open
image
  1. Keep going with the next sections

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, you need to fix all comments from the previous review. Also request the next review after you finish the entire landing page

@zhudim
Copy link
Author

zhudim commented Nov 14, 2024

Could you please tell me what exactly I need to change to make the assignment count?

Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please request the review of this request when you finish the whole project, and you will finish it in the next lessons

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants