Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #1812

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

Develop #1812

wants to merge 20 commits into from

Conversation

BeginerAI
Copy link

@TarasHoliuk
Copy link

  1. I'd just change some property on hover - it's more "usual" in such cases (in this case transition should work in both ways - when hover and blur). If you want to keep animation you can keep it, but add same animation to all images for consistency

image

  1. It should be links (also, read checklist):

image

  1. Add padding to inputs:
    image

  2. Your app (also, check the font-weight):

image

Design:
image

  1. Export SVG images from the figma and use them for icons and logo:
    image

  2. Design:

image

Your app (check font family here and everywhere else):

image

  1. Read the checklist, make sure you've reached all points from there

Copy link

@TarasHoliuk TarasHoliuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start! Pay attention to the checklist and font styles in the design

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍
Let's improve your page

  1. Fix the placeholder text, check it on the design and add the left padding for the text
image
  1. Change the autofill styles for the form fields
    https://css-tricks.com/snippets/css/change-autocomplete-styles-webkit-browsers/
image
  1. Add cursor pointer for this button
image
  1. Fix color for these links
image
  1. This element must be link with mail to
image
  1. Also, fix the address here on google maps, this link is wrong now
image
  1. Remove the right padding here
image
  1. Hide the additional phone number on the mobile and tablet versions
image

@BeginerAI
Copy link
Author

BeginerAI commented Nov 13, 2024

Hello! I don't quite understand about the mail, it is tied to Gmail

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, you need to fix all comments from the previous review, you need to fix text placeholder, check it on the design

Also, you need to use mailto: for mail, you can read more here
https://www.w3schools.com/tags/tryit.asp?filename=tryhtml_link_mailto

@BeginerAI
Copy link
Author

Done, fixed the issues above

@BeginerAI
Copy link
Author

image
no button for repeat revue ((

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants