-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop #1812
base: main
Are you sure you want to change the base?
Develop #1812
Conversation
Your app (check font family here and everywhere else):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good start! Pay attention to the checklist and font styles in the design
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job 👍
Let's improve your page
- Fix the placeholder text, check it on the design and add the left padding for the text
- Change the autofill styles for the form fields
https://css-tricks.com/snippets/css/change-autocomplete-styles-webkit-browsers/
- Add cursor pointer for this button
- Fix color for these links
- This element must be link with mail to
- Also, fix the address here on google maps, this link is wrong now
- Remove the right padding here
- Hide the additional phone number on the mobile and tablet versions
Hello! I don't quite understand about the mail, it is tied to Gmail |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, you need to fix all comments from the previous review, you need to fix text placeholder, check it on the design
Also, you need to use mailto:
for mail, you can read more here
https://www.w3schools.com/tags/tryit.asp?filename=tryhtml_link_mailto
Done, fixed the issues above |
-DEMO LINK