Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

landing page done #1810

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

landing page done #1810

wants to merge 4 commits into from

Conversation

mtereshyn
Copy link

@mtereshyn mtereshyn commented Nov 10, 2024 •
edited
Loading

volodymyr-soltys97
volodymyr-soltys97 suggested changes Nov 11, 2024
View reviewed changes
Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, there is no demo link, also, you need to add demo link to the PR description
image

volodymyr-soltys97
volodymyr-soltys97 suggested changes Nov 11, 2024
View reviewed changes
Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍
Let's improve your page

  1. Fix styles for the phone number, check it on the design
image
  1. Need to remove scroll when the menu is open
image
  1. The images shouldn't overlap each other when hovering
image
  1. Fix default background color for this button and add cursor pointer here
image
  1. Make all these fields are required before sending
image
  1. Add hover effects here
image
  1. Hide the additional phone number on the mobile and tablet versions
image

@mtereshyn
Copy link
Author

mtereshyn commented Nov 11, 2024 •
edited
Loading

  1. Need to remove scroll when the menu is open

Can you help me with this issue?

Other bugs resolved

VitaliyBondarenko1982
VitaliyBondarenko1982 approved these changes Nov 11, 2024
View reviewed changes
Copy link

@VitaliyBondarenko1982 VitaliyBondarenko1982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VitaliyBondarenko1982 VitaliyBondarenko1982 VitaliyBondarenko1982 approved these changes

@volodymyr-soltys97 volodymyr-soltys97 Awaiting requested review from volodymyr-soltys97

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mtereshyn @VitaliyBondarenko1982 @volodymyr-soltys97