Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add task solution #1801

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

add task solution #1801

wants to merge 10 commits into from

Conversation

kovaltar
Copy link

@kovaltar kovaltar commented Nov 6, 2024

SanyaBratashchuk
SanyaBratashchuk suggested changes Nov 6, 2024
View reviewed changes
Copy link

@SanyaBratashchuk SanyaBratashchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. disable scroll when menu is open
    image
  2. should be links
    image
  3. page shouldn't be refresh after form submit

volodymyr-soltys97
volodymyr-soltys97 suggested changes Nov 8, 2024
View reviewed changes
Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done!
To improve:

  1. Hide the additional phone number on the mobile and tablet versions
image
  1. The font family must be are same everywhere
image
  1. Fix the background image, check it on the design. The top cyclist must not be clipped
image

etojeDenys
etojeDenys approved these changes Nov 8, 2024
View reviewed changes
Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etojeDenys etojeDenys etojeDenys approved these changes

@SanyaBratashchuk SanyaBratashchuk Awaiting requested review from SanyaBratashchuk

@volodymyr-soltys97 volodymyr-soltys97 Awaiting requested review from volodymyr-soltys97

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kovaltar @volodymyr-soltys97 @etojeDenys @SanyaBratashchuk