Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop #1799

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Develop #1799

wants to merge 6 commits into from

Conversation

MiltonMario
Copy link

@MiltonMario MiltonMario commented Nov 6, 2024 •
edited
Loading

raulriato
raulriato suggested changes Nov 8, 2024
View reviewed changes
Copy link

@raulriato raulriato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You did a really good job there!

Just need some minor improvements.

Besides the specific reviews, you could use the cursor: pointer more in your styles, on buttons, for example.

src/index.html Show resolved Hide resolved
src/index.html Show resolved Hide resolved
src/index.html Outdated Show resolved Hide resolved
src/styles/blocks/product.scss Show resolved Hide resolved
src/index.html Outdated Show resolved Hide resolved
raulriato
raulriato suggested changes Nov 13, 2024
View reviewed changes
Copy link

@raulriato raulriato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your project is almost perfect. There's just one change you need to make.

Well done!

src/styles/blocks/recommended.scss Show resolved Hide resolved
raulriato
raulriato approved these changes Nov 14, 2024
View reviewed changes
Copy link

@raulriato raulriato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulriato raulriato raulriato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MiltonMario @raulriato