Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar with wrong font #3952

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Farrelzum
Copy link

  • DEMO LINK

  • TEST REPORT LINK

  • [x ] Changing 'month-lengh' and 'start-day' modifier in the code element
    reflects in changing calendar layout

  • Each day has no modifiers, only class (eg. calendar__day)

  • All Typical Mistakes from BEM lesson theory are checked.

  • Code follows all the Code Style Rules ❗️

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your hard work on this project! 🌟 There are a couple of critical issues that need to be addressed before we can approve this pull request. Firstly, the SCSS file is linked directly in the HTML, which is not valid. Please compile your SCSS into CSS and link the CSS file instead. Secondly, there's a typo in the SCSS color property value (bla), which should be corrected to a valid color like black or #000. Once these issues are resolved, your project will be in great shape! Keep up the great work! 💪

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

@@ -9,10 +9,42 @@
<title>Calendar</title>
<link
rel="stylesheet"
href="styles/index.scss"
href="styles/main.scss"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The href attribute is linking to a SCSS file (styles/main.scss). HTML cannot directly use SCSS files. You need to compile the SCSS into a CSS file and link to that CSS file instead.

align-items: center;
font-family: Arial, sans-serif;
font-size: 30px;
color: bla;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a typo in the color property value: 'bla'. It should be corrected to a valid color value, such as 'black' or a hex code like '#000'.


font-family: Arial, sans-serif;
font-size: 30px;
color: bla;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a typo in the color property value: 'bla'. It should be corrected to a valid color value, such as 'black' or a hex code like '#000'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants