Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

task solution #3941

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

task solution #3941

wants to merge 4 commits into from

Conversation

troleksii
Copy link

mateacademy-ai-mentor
mateacademy-ai-mentor approved these changes Nov 12, 2024
View reviewed changes
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the calendar! 🎉 The structure and styling are well done, and you've met all the task requirements. Just a small note: ensure consistency in units within your $days map to avoid any potential issues. Keep up the fantastic work! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

src/styles/index.scss
Comment on lines +4 to +5
'mon': 5,
'tue': 101px,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the $days map, the value for 'mon' is given as 5 without a unit, while 'tue' has 101px. Ensure all values in the map have consistent units (e.g., px) for consistency and to avoid potential issues in calculations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateacademy-ai-mentor mateacademy-ai-mentor mateacademy-ai-mentor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@troleksii @mateacademy-ai-mentor