Homework 3 completed #156
Open
Homework 3 completed #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| for (int i = 0; value > 0; i++) { | ||
| binaryResult.append(((value % 2) == 0 ? "0" : "1")); |
There was a problem hiding this comment.
do we need ternary operator here?
what's gonna happen if we just remove it?
| return "0"; | ||
| } | ||
|
|
||
| for (int i = 0; value > 0; i++) { |
There was a problem hiding this comment.
this loop doesn't make a lot of sense, let's use while loop
| @@ -7,6 +7,17 @@ | |||
| * а возвращает String с представлением этого числа в двоичном виде. | |||
| */ | |||
| public String toBinaryString(int value) { | |||
| return null; | |||
| StringBuilder binaryResult = new StringBuilder(); | |||
|
|
|||
There was a problem hiding this comment.
let's remove this empty line, it's redundant
| if (value == 0) { | ||
| return "0"; | ||
| } | ||
|
|
RomanDubovskyi
approved these changes
Jul 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.