Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HW-2 #146

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

HW-2 #146

wants to merge 2 commits into from

Conversation

OleksiiTromsa
Copy link

No description provided.

Sofasmile
Sofasmile reviewed Jul 27, 2020
View reviewed changes
src/main/java/core/basesyntax/BinaryString.java Outdated
return "0";
}

StringBuffer result = new StringBuffer();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

read checklist attentively

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to StringBuilder. Will ask you tomorrow, why not StringBuffer or String.format() for example :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://www.javatpoint.com/difference-between-stringbuffer-and-stringbuilder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sofasmile Sofasmile Sofasmile approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OleksiiTromsa @Sofasmile